Improve notification banner transitions #5170
Conversation
IOS-155 Improve notification banner transitions
Notification banner animations might get choppy if many notifications are fired quickly after each other. A solution to this could be to stop the property animator and restart a new one from the previous position. |
rablador
force-pushed
the
improve-notification-banner-transitions-ios-155
branch
from
896468a to
1555cf2
Compare
There was a problem hiding this comment.
There was a proposal to use newly added API callback viewIsAppearing(_:) for calling view.layoutIfNeeded() instead of currently used toggleBanner(). This causes regression and introduces horisontal expansion. Leaving it where it's currently at and not setting bannerView to hidden removes all choppy or weird animation behavior that I could find.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
There was a problem hiding this comment.
nice !
Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
buggmagnet
force-pushed
the
improve-notification-banner-transitions-ios-155
branch
from
1555cf2 to
b85f1b2
Compare
buggmagnet
deleted the
improve-notification-banner-transitions-ios-155
branch
Notification banner animations might get choppy if many notifications are fired quickly after each other.
This change is